-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding recipe for Himalaya #4681
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The build fails because a (required) FORTRAN compiler is missing. How can I fix this? Should I exclude MacOS? (In principle this is not necessary, because one can install gfortran on MacOS via brew.) |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
It seems like gfortran is in trouble. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Would it ok, if MacOS support would currently be disabled for this package? This would at least allow using the package on all the other platforms for the moment. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm sorry, but I'm not sure what I can do to help with this issue. Is there any workaround that can be used for the moment? |
This recipe requires gfortran. Our current recipe is broken. We have some options here:
All three are complex, but the easiest is the second. |
def config_options(self): | ||
if self.settings.os == "Windows": | ||
del self.options.fPIC | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def configure(self): | |
if self.options.shared: | |
del self.options.fPIC | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the proposal!
But tbh, why should fPIC be deleted if shared
is enabled? Isn't this the wrong way around?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes no sense disabling fPIC when building shared library, so we disable it. Otherwise, it would affect the package ID, for both values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now I think I understand. :) You are saying that since Himalaya always builds a shared library, the fPIC
option can be deleted completely. Is this correct?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
Failure in build 14 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Expander I have some good news. We are developing new docker images with fortran supported. They should become official in some months, but unfortunately we can't your case right now. The gfortran package is broken and only way that I see to fix it, is importing all gcc libraries and apps (not good idea). |
Many thanks for the good news! Then let's wait with this PR until fortran is available. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: himalaya/4.1.0
conan-center hook activated.